Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test succinct delegations #127

Open
jku opened this issue Aug 12, 2024 · 1 comment · May be fixed by #141
Open

Test succinct delegations #127

jku opened this issue Aug 12, 2024 · 1 comment · May be fixed by #141

Comments

@jku
Copy link
Member

jku commented Aug 12, 2024

This is not on any critical path (as I don't know of repositories using succinct delegations) but:

We should add a basic test for succinct delegations at some point:

  • I don't remember how the spec defines this but I would consider this an optional feature of the spec so should make this easy to make "expected to fail"
  • there is some functionality in RepositorySimulator to create these things already
@jku jku linked a pull request Aug 14, 2024 that will close this issue
@jku
Copy link
Member Author

jku commented Aug 14, 2024

I don't remember how the spec defines this but I would consider this an optional feature of the spec so should make this easy to make "expected to fail"

Turns out this is still an augmentation proposal: we'll have to figure out how we handle optional features.
My first instinct is just action inputs like

tap15-succinct-hashed-bin-delegations:
   default: "false"

and some way to do that with the command line as well

@AdamKorcz AdamKorcz linked a pull request Aug 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant