Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for novalue filter, Values 0 (zero) and false are transformed to {"Ref": "AWS::NoValue"} #175

Open
rohitmisra opened this issue Jul 11, 2021 · 0 comments

Comments

@rohitmisra
Copy link
Contributor

rohitmisra commented Jul 11, 2021

0 and false are valid values for configuration in cloudformation.
Eg.
"DuplicatesAllowed": false
"Required": false
ReservedConcurrentExecutions: 0

In such cases, 0 or false is not the same as {"Ref": "AWS::NoValue"}
Hence, ReservedConcurrentExecutions: {{ ReservedConcurrentExecutions | novalue }} is not useful when I want to set ReservedConcurrentExecutions to 0.

Here is a pull request for the fix:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant