Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more graceful response if successful challenge-response but the challenger quit the session #28

Closed
therealpaulgg opened this issue Feb 27, 2024 · 1 comment · Fixed by #39

Comments

@therealpaulgg
Copy link
Owner

therealpaulgg commented Feb 27, 2024

Example of this behavior:

Client starts challenge, and quits (ctrl+c)

On other machine this happens:

ssh-sync challenge-response
Please enter the challenge phrase: stranger-enzyme-buckshot
failed to parse PEM encoded key: failed to decode PEM data

Expected behavior would be that the challenge should clean itself up when the challenger quits their session, and when the challenge response occurs it should say invalid challenge.

ssh-sync challenge-response
Please enter the challenge phrase: stranger-enzyme-buckshot
error from server: Invalid challenge response
@therealpaulgg therealpaulgg linked a pull request Mar 21, 2024 that will close this issue
@therealpaulgg
Copy link
Owner Author

This is fixed in this pull request. therealpaulgg/ssh-sync-server#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant