Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .ssh instead of .ssh-sync-data. Perhaps add a 'safe' mode #24

Closed
therealpaulgg opened this issue Apr 26, 2023 · 1 comment · Fixed by #50
Closed

Use .ssh instead of .ssh-sync-data. Perhaps add a 'safe' mode #24

therealpaulgg opened this issue Apr 26, 2023 · 1 comment · Fixed by #50
Assignees

Comments

@therealpaulgg
Copy link
Owner

By 'safe' mode, if the user has keys currently in the directory, provide some kind of interface for the user to allow the user to prevent ssh-sync from overwriting keys.

This may apply to both 'upload' and 'download'

@therealpaulgg therealpaulgg converted this from a draft issue Apr 26, 2023
@therealpaulgg
Copy link
Owner Author

therealpaulgg commented Mar 20, 2024

We should review .ssh-sync-data and make sure that we aren't explicitly deleting files. It would be bad to overwrite files without the user knowing...

Perhaps prompt the user and let them know if a key will be overwritten and the contents are different from what is stored on remote?

Is the config ordered the same each time it is generated, or does the order vary?

Let's use sha256sum to compare current files to new ones & warn

@therealpaulgg therealpaulgg self-assigned this Mar 21, 2024
@therealpaulgg therealpaulgg moved this from Todo to In Progress in ssh-sync Mar 27, 2024
@therealpaulgg therealpaulgg linked a pull request Apr 3, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in ssh-sync Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant