Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlowbiteThemable does not correctly style outline buttons. #179

Open
grahamsutton opened this issue Jul 31, 2023 · 2 comments
Open

FlowbiteThemable does not correctly style outline buttons. #179

grahamsutton opened this issue Jul 31, 2023 · 2 comments
Labels
🪲 bug Something isn't working

Comments

@grahamsutton
Copy link

grahamsutton commented Jul 31, 2023

When using Button components wrapped in FlowbiteThemable, the button text and borders do not match the theme color. Additionally, the background color is being applied when it should not be (because it's an outline).

Screenshot 2023-07-31 at 2 23 13 PM

(The 1w button is a regular button that looks selected.)

Code sample (not from screenshot):

<script setup>
import { Button, FlowbiteThemable } from 'flowbite-vue'
</script>

<template>
  <FlowbiteThemable theme="pink">
    <Button outline>Click me</Button>
  </FlowbiteThemable>
</template>

These are the CSS classes being applied:

text-blue-700 border border-blue-700 focus:ring-pink-300 focus:outline-none font-medium rounded-lg dark:border-blue-500 dark:text-blue-500 dark:focus:ring-pink-900 hover:text-white hover:bg-pink-800 dark:hover:text-white dark:hover:bg-pink-700 px-4 py-2 bg-pink-700 dark:bg-pink-600 text-blue-700 border border-blue-700 focus:ring-4 focus:outline-none focus:ring-blue-300 font-medium rounded-lg text-sm text-center dark:border-blue-500 dark:text-blue-500 dark:focus:ring-blue-800 hover:text-white hover:bg-blue-800 dark:hover:text-white dark:hover:bg-blue-600 text-sm px-4 py-2

Most classes appear to not apply any theme styling, while some do, such as focus, hover, bg, and dark. However, some of those styles appear to get overridden by default classes.

This works fine for regular buttons where :outline="false". Current workaround is having to apply external styles.

@cogor cogor added the 🪲 bug Something isn't working label Aug 25, 2023
@cogor
Copy link
Collaborator

cogor commented Sep 13, 2023

Hi, FlowbiteThemable isn't ready yet, I'll work on it after migration to tailwind-merge for components classes

@cogor
Copy link
Collaborator

cogor commented Sep 13, 2023

You can track these issues #192 and #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
Development

No branches or pull requests

2 participants