-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[merlin_magic] harden workflow against failures due to sonnei typing disagreement #600
Comments
and to add on to this, when this occurs, and the
The resolution to get TheiaProk to succeed is to set |
Here's the offending genome in the GAMBIT database that is labeled as Shigella sonnei by the submitter/NCBI, but should probably be corrected to E. coli NCBI's own ANI analysis shows it's closer to an E. coli than the closest Shigella sonnei genome: |
Here are some other Shigella genomes in the GAMBIT database that are worth looking into. These resulted in similar issues during our validation of TheiaProk. Thank you for looking into this! [GCF_002249045.1] Shigella boydii subspecies 2 |
🆒
📌 Explain the Request
Currently, merlin magic will fail if gambit predicts Shigella Sonniei, but Shigatyper "disagrees." Expand logic for sonneityping to simply output empty result in these instances. For more context, see slack messages https://theiagen.slack.com/archives/C04GMT7TPTR/p1724974576036859
The text was updated successfully, but these errors were encountered: