From ad3eec14720504ea641cfd4a4ae059a39a94c010 Mon Sep 17 00:00:00 2001 From: Kane Cheshire Date: Mon, 15 Jan 2018 11:23:52 +0000 Subject: [PATCH 1/2] Removes call to `super` and calls `main` in `start()` --- .../Operations/BaseAsynchronousOperation.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/TABResourceLoader/Operations/BaseAsynchronousOperation.swift b/Sources/TABResourceLoader/Operations/BaseAsynchronousOperation.swift index aa51273..a731967 100644 --- a/Sources/TABResourceLoader/Operations/BaseAsynchronousOperation.swift +++ b/Sources/TABResourceLoader/Operations/BaseAsynchronousOperation.swift @@ -68,8 +68,8 @@ open class BaseAsynchronousOperation: Operation { } public final override func start() { - super.start() self.isExecuting = true + main() } public final override func main() { From cd1634f27a0f3a41fa33b32e9b7f1adedee71cd7 Mon Sep 17 00:00:00 2001 From: Kane Cheshire Date: Mon, 15 Jan 2018 11:26:19 +0000 Subject: [PATCH 2/2] Updated CHANGELOG/podspec --- CHANGELOG.md | 10 +++++++--- TABResourceLoader.podspec | 3 +-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7749e21..77e3ce0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Change Log +## 7.2.1 + +- Fixes an issue where `super.start()` was being called unnecessarily. + ## 7.2.0 - Adds the ability to cancel all requests from the resource service. @@ -31,7 +35,7 @@ ## 5.0.0 -- The error from a failed `NetworkResponse` is now flattened and moved into the `NetworkServiceError` `couldNotParseModel` case to avoid nested switch statements: +- The error from a failed `NetworkResponse` is now flattened and moved into the `NetworkServiceError` `couldNotParseModel` case to avoid nested switch statements: ```swift enum NetworkResponse { @@ -50,7 +54,7 @@ enum NetworkResponse { // New interface func model(from data: Data) throws -> Model ``` - + - `JSONDictionaryResourceType` transformation function now throws on failure instead of returning `Model?`: ```swift @@ -68,7 +72,7 @@ enum NetworkResponse { // New interface func model(from jsonArray: [Any]) throws -> Model ``` - + - Refactored network service - Renamed `NetworkDataResourceService` to `GenericNetworkDataResourceService`, this is useful when using it with `ResourceOperation` - New `NetworkDataResourceService` uses a generic fetching function diff --git a/TABResourceLoader.podspec b/TABResourceLoader.podspec index bb8db98..ecf519b 100644 --- a/TABResourceLoader.podspec +++ b/TABResourceLoader.podspec @@ -1,7 +1,7 @@ Pod::Spec.new do |spec| spec.name = 'TABResourceLoader' spec.homepage = 'https://github.com/theappbusiness/TABResourceLoader' - spec.version = '7.2.0' + spec.version = '7.2.1' spec.license = { :type => 'MIT' } spec.authors = { 'Luciano Marisi' => 'luciano@techbrewers.com' } spec.summary = 'Framework for loading resources from a network service' @@ -12,4 +12,3 @@ Pod::Spec.new do |spec| spec.source_files = 'Sources/**/*.swift' spec.ios.deployment_target = '8.0' end -