From bd05cdd7e7b3a2346380e2fcdd8fe93e9c066946 Mon Sep 17 00:00:00 2001 From: Michael Ritchie Date: Thu, 15 Nov 2018 10:30:47 -0300 Subject: [PATCH] * Suppress error MQTT error message on Android 5.0 --- .../iot/mqtt/alarmpanel/BaseActivity.kt | 20 +++++++++++-------- .../alarmpanel/network/AlarmPanelService.kt | 16 +++++++-------- build.gradle | 4 ++-- 3 files changed, 21 insertions(+), 19 deletions(-) diff --git a/app/src/main/java/com/thanksmister/iot/mqtt/alarmpanel/BaseActivity.kt b/app/src/main/java/com/thanksmister/iot/mqtt/alarmpanel/BaseActivity.kt index 9b654424..25be8b40 100644 --- a/app/src/main/java/com/thanksmister/iot/mqtt/alarmpanel/BaseActivity.kt +++ b/app/src/main/java/com/thanksmister/iot/mqtt/alarmpanel/BaseActivity.kt @@ -190,16 +190,20 @@ abstract class BaseActivity : DaggerAppCompatActivity() { * with the alarm disabled because the disable time will be longer than this. */ open fun showScreenSaver() { - if (!configuration.isAlarmTriggeredMode() && configuration.hasScreenSaver() && !isFinishing() ) { + if (!configuration.isAlarmTriggeredMode() && configuration.hasScreenSaver() && !isFinishing) { inactivityHandler.removeCallbacks(inactivityCallback) val hasWeather = (configuration.showWeatherModule() && darkSkyOptions.isValid) - dialogUtils.showScreenSaver(this@BaseActivity, - configuration.showPhotoScreenSaver(), - imageOptions, - View.OnClickListener { - dialogUtils.hideScreenSaverDialog() - resetInactivityTimer() - }, darkSkyDataSource, hasWeather) + try { + dialogUtils.showScreenSaver(this@BaseActivity, + configuration.showPhotoScreenSaver(), + imageOptions, + View.OnClickListener { + dialogUtils.hideScreenSaverDialog() + resetInactivityTimer() + }, darkSkyDataSource, hasWeather) + } catch (e: Exception) { + Timber.e(e.message) + } } } diff --git a/app/src/main/java/com/thanksmister/iot/mqtt/alarmpanel/network/AlarmPanelService.kt b/app/src/main/java/com/thanksmister/iot/mqtt/alarmpanel/network/AlarmPanelService.kt index b62407a0..a0aabb45 100644 --- a/app/src/main/java/com/thanksmister/iot/mqtt/alarmpanel/network/AlarmPanelService.kt +++ b/app/src/main/java/com/thanksmister/iot/mqtt/alarmpanel/network/AlarmPanelService.kt @@ -330,9 +330,9 @@ class AlarmPanelService : LifecycleService(), MQTTModule.MQTTListener { } override fun onMQTTDisconnect() { - Timber.e("onMQTTDisconnect") + Timber.w("onMQTTDisconnect") if(hasNetwork()) { - if(!mqttAlertMessageShown) { + if(!mqttAlertMessageShown && Build.VERSION.SDK_INT > Build.VERSION_CODES.LOLLIPOP) { mqttAlertMessageShown = true sendAlertMessage(getString(R.string.error_mqtt_connection)) } @@ -341,9 +341,9 @@ class AlarmPanelService : LifecycleService(), MQTTModule.MQTTListener { } override fun onMQTTException(message: String) { - Timber.e("onMQTTException: $message") + Timber.w("onMQTTException: $message") if(hasNetwork()) { - if(!mqttAlertMessageShown) { + if(!mqttAlertMessageShown && Build.VERSION.SDK_INT > Build.VERSION_CODES.LOLLIPOP) { mqttAlertMessageShown = true sendAlertMessage(getString(R.string.error_mqtt_exception)) } @@ -351,11 +351,9 @@ class AlarmPanelService : LifecycleService(), MQTTModule.MQTTListener { } } - private val restartMqttRunnable = object: Runnable { - override fun run() { - if (mqttModule != null) { - mqttModule!!.restart() - } + private val restartMqttRunnable = Runnable { + if (mqttModule != null) { + mqttModule!!.restart() } } diff --git a/build.gradle b/build.gradle index e80d2999..a81fd6d3 100644 --- a/build.gradle +++ b/build.gradle @@ -53,10 +53,10 @@ def versions = [:] versions.lifecycle = "1.1.1" versions.support = "27.1.1" versions.kotlin = "1.2.20" -versions.navigation = "1.0.0-alpha03" +versions.navigation = "1.0.0-alpha07" versions.min_sdk = 16 versions.target_sdk = 27 -versions.constraint_layout = "1.1.0" +versions.constraint_layout = "1.1.3" versions.retrofit = "2.2.0" versions.stetho = "1.3.1" versions.dagger = "2.15"