Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing the relationship between time windows #23

Open
pasqu4le opened this issue Mar 1, 2022 · 0 comments
Open

Consider changing the relationship between time windows #23

pasqu4le opened this issue Mar 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@pasqu4le
Copy link
Contributor

pasqu4le commented Mar 1, 2022

Clarification and motivation

Currently, as per the spec, each proposal has 3 relevant timestamps

  1. a creation time, corresponding to when it is submitted
  2. a voting time, when voting starts, set on submission to begin some vote_delay time after the creation time
  3. an expiration time, when it is concluded, set on submission to occur some expire_time time after the creation time

This is however a bit awkward because someone could submit their proposal with an expire_time smaller than their vote_delay, which would cause a proposal to expire before voting is allowed.

We have some choices on how to handle this:

  1. check for expire_time to be smaller than vote_delay when the proposal is submitted, fail otherwise
  2. make the expiration time start some expire_time time after the voting time
  3. ignore this potential problem in the contract, have it be handled in the off-chain app instead

Acceptance criteria

A decision is taken and if necessary the specification and the smart contract are updated accordingly.

@pasqu4le pasqu4le added the enhancement New feature or request label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant