You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I have a working implementation of an Etcd container, but in order to test it, the appropriate crate that would be required is https://github.com/etcdv3/etcd-client
The issue here is that this crate requires protobuf as an OS dependency, which might break the CI environment or some users workflow. There are other libraries that could do the trick, but those are less popular.
Any advice on the desired way to proceed is appreciated.
Image reference
No response
The text was updated successfully, but these errors were encountered:
Since this is only for testing, we can easily specify this as a prerequisite for running tests (contributing guide #1?) and update our CI. This will not affect users of the modules in any way. But only contributors.
In addition, we can consider to use just for testing (with check of prerequisites) and linting (fmt, clippy)
However, we can choose the easier way to test too, because we need to ensure that container is started and operating properly(healthy).
I mean even less popular client may work if it's alive.
This way we will avoid extra requirements for contributors.
So I'd try to avoid extra complicated deps if possible
Feature request description
Hi, I have a working implementation of an Etcd container, but in order to test it, the appropriate crate that would be required is https://github.com/etcdv3/etcd-client
The issue here is that this crate requires
protobuf
as an OS dependency, which might break the CI environment or some users workflow. There are other libraries that could do the trick, but those are less popular.Any advice on the desired way to proceed is appreciated.
Image reference
No response
The text was updated successfully, but these errors were encountered: