Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid_max should return the last grid point rather than the upper bound of the interval for includeendpoint=false #7

Open
shinaoka opened this issue Jul 16, 2024 · 2 comments

Comments

@shinaoka
Copy link
Member

If includeendpoint=false, grid_max should return the last point of the grid, rather than the supremum.

We could introduce grid_supremum returning b for $[a, b)$.

@shinaoka
Copy link
Member Author

shinaoka commented Jul 16, 2024

I got my head around this point. supremum is mathematically correct, but sounds unfamiliar. How about the following.

  • Rename the attributes of DiscretizedGrid as grid_max -> upper_bound and grid_min to lower_bound.
  • grid_max function returns the last grid point.
  • We introduce upper_bound and lower_bound functions.

@shinaoka shinaoka changed the title Invalid grid_max for includeendpoint=false grid_max should return the last grid point rather than the upper bound of the interval for includeendpoint=false Jul 16, 2024
@shinaoka
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant