From 78e2886748fd61b3a665275185170043c53bca5f Mon Sep 17 00:00:00 2001 From: rodrigozhou Date: Tue, 21 Jan 2025 14:10:21 -0800 Subject: [PATCH] address comments --- openapi/openapiv2.json | 4 ++-- openapi/openapiv3.yaml | 2 +- temporal/api/workflowservice/v1/request_response.proto | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/openapi/openapiv2.json b/openapi/openapiv2.json index 882d1d4f..7838d3aa 100644 --- a/openapi/openapiv2.json +++ b/openapi/openapiv2.json @@ -6536,7 +6536,7 @@ }, "onConflictOptions": { "$ref": "#/definitions/v1OnConflictOptions", - "description": "It defines actions to be done to the existing running workflow when the conflict policy\nWORKFLOW_ID_CONFLICT_POLICY_USE_EXISTING is used. If not set (ie., nil value) or set to a\nempty object (ie., all options with default value), it won't do anything to the existing\nrunning workflow. If set, it will add a history event to the running workflow." + "description": "Defines actions to be done to the existing running workflow when the conflict policy\nWORKFLOW_ID_CONFLICT_POLICY_USE_EXISTING is used. If not set (ie., nil value) or set to a\nempty object (ie., all options with default value), it won't do anything to the existing\nrunning workflow. If set, it will add a history event to the running workflow." } } }, @@ -12044,7 +12044,7 @@ }, "onConflictOptions": { "$ref": "#/definitions/v1OnConflictOptions", - "description": "It defines actions to be done to the existing running workflow when the conflict policy\nWORKFLOW_ID_CONFLICT_POLICY_USE_EXISTING is used. If not set (ie., nil value) or set to a\nempty object (ie., all options with default value), it won't do anything to the existing\nrunning workflow. If set, it will add a history event to the running workflow." + "description": "Defines actions to be done to the existing running workflow when the conflict policy\nWORKFLOW_ID_CONFLICT_POLICY_USE_EXISTING is used. If not set (ie., nil value) or set to a\nempty object (ie., all options with default value), it won't do anything to the existing\nrunning workflow. If set, it will add a history event to the running workflow." } } }, diff --git a/openapi/openapiv3.yaml b/openapi/openapiv3.yaml index 539a29c1..7118020d 100644 --- a/openapi/openapiv3.yaml +++ b/openapi/openapiv3.yaml @@ -9432,7 +9432,7 @@ components: allOf: - $ref: '#/components/schemas/OnConflictOptions' description: |- - It defines actions to be done to the existing running workflow when the conflict policy + Defines actions to be done to the existing running workflow when the conflict policy WORKFLOW_ID_CONFLICT_POLICY_USE_EXISTING is used. If not set (ie., nil value) or set to a empty object (ie., all options with default value), it won't do anything to the existing running workflow. If set, it will add a history event to the running workflow. diff --git a/temporal/api/workflowservice/v1/request_response.proto b/temporal/api/workflowservice/v1/request_response.proto index dd0e7097..b583eada 100644 --- a/temporal/api/workflowservice/v1/request_response.proto +++ b/temporal/api/workflowservice/v1/request_response.proto @@ -206,7 +206,7 @@ message StartWorkflowExecutionRequest { // If set, takes precedence over the Versioning Behavior sent by the SDK on Workflow Task completion. // To unset the override after the workflow is running, use UpdateWorkflowExecutionOptions. temporal.api.workflow.v1.VersioningOverride versioning_override = 25; - // It defines actions to be done to the existing running workflow when the conflict policy + // Defines actions to be done to the existing running workflow when the conflict policy // WORKFLOW_ID_CONFLICT_POLICY_USE_EXISTING is used. If not set (ie., nil value) or set to a // empty object (ie., all options with default value), it won't do anything to the existing // running workflow. If set, it will add a history event to the running workflow.