Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make socket callbacks sk_fill_write_queue and sk_write_xmit reentable or close connection in case of -ENOMEM #2154

Closed
EvgeniiMekhanik opened this issue Jun 28, 2024 · 3 comments
Labels
Milestone

Comments

@EvgeniiMekhanik
Copy link
Contributor

There are a lot of bugs which can occur if we catch -ENOMEM during sk_fill_write_queue or sk_write_xmit execution. They occur because we don't close connection in case of -ENOMEM error in this functions but only wait until memory will be available and call this functions again. This functions are not reentable so there are a lot of bugs. For example we call skb_push in sk_write_xmit->tfw_tls_encrypt for skb again and again until bug occurs in case of -ENOMEM.

@krizhanovsky krizhanovsky added this to the 0.9 - LA milestone Jun 28, 2024
@krizhanovsky
Copy link
Contributor

Probably is good to do with #1504

@EvgeniiMekhanik
Copy link
Contributor Author

There are a lot of bugs which depends on this fix #2042 2120,

@EvgeniiMekhanik
Copy link
Contributor Author

Closed by #2168. We decide to close connection in case of ENOMEM and it was implemented in 2168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants