Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inversed logic for http_trailer_split_allowed #1725

Closed
krizhanovsky opened this issue Oct 14, 2022 · 0 comments · Fixed by #1750
Closed

Inversed logic for http_trailer_split_allowed #1725

krizhanovsky opened this issue Oct 14, 2022 · 0 comments · Fixed by #1750
Assignees
@b3b
Labels
bug good to start Start form this tasks if you're new in Tempesta FW
Milestone
0.7 - HTTP/2

Comments

@krizhanovsky
Copy link
Contributor

Motivation

http_trailer_split_allowed true must allow the same header in the headers and trailers parts, but not it's inversed, see tempesta-tech/tempesta-test#265 (comment)

Testing

t_frang.test_http_trailer_split_allowed.FrangHttpTrailerSplitLimitOnTestCase implements the test
@krizhanovsky krizhanovsky added bug good to start Start form this tasks if you're new in Tempesta FW labels Oct 14, 2022
@krizhanovsky krizhanovsky mentioned this issue Oct 14, 2022
Merged
b3b added a commit that referenced this issue Nov 10, 2022
@b3b
Fix inversed logic for http_trailer_split_allowed (#1725)
44cc98d
b3b added a commit that referenced this issue Nov 10, 2022
@b3b
Fix inversed logic for http_trailer_split_allowed (#1725)
1726217
@b3b b3b mentioned this issue Nov 10, 2022
Merged
@b3b b3b closed this as completed in #1750 Nov 11, 2022
b3b added a commit that referenced this issue Nov 11, 2022
@b3b
Merge pull request #1750 from tempesta-tech/as-1725-trailer-inverse
36531dd 
Fix inversed logic for http_trailer_split_allowed (#1725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b3b b3b

Labels
bug good to start Start form this tasks if you're new in Tempesta FW
Projects
None yet
Milestone
0.7 - HTTP/2
Development

Successfully merging a pull request may close this issue.

Fix inversed logic for http_trailer_split_allowed (#1725) tempesta-tech/tempesta
2 participants
@krizhanovsky @b3b