You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tests are run on the default port 80. This port is default for the service requested. Therefore, it does not need to be specified. But now, frang does not allow requests that do not specify a port, even if it is port 80.
Example:
now:
request fails due to limit:
GET http://tempesta-tech.com:80/ HTTP/1.1\r
Host: tempesta-tech.com\r
\r
Required: the request passes because port 80 is a port that doesn't have to be specified
Testing
t_frang.test_http_strict_host_checking.FrangHostRequiredTestCase.test_host_header_no_port_in_host - this test is currently disabled, but if enabled, it will pass. After this bug is fixed, you will need to transfer this case to the test_host_header_set_ok test in the same file.
h2 and http1.1 has same problem with ipv6. This works correctly for ipv4. But if send request with host: [20:11:abb::1] header, we will receive response status - 400.
Motivation
all tests should work
Scope
Tests are run on the default port 80. This port is default for the service requested. Therefore, it does not need to be specified. But now, frang does not allow requests that do not specify a port, even if it is port 80.
Example:
now:
request fails due to limit:
Required: the request passes because port 80 is a port that doesn't have to be specified
Testing
t_frang.test_http_strict_host_checking.FrangHostRequiredTestCase.test_host_header_no_port_in_host - this test is currently disabled, but if enabled, it will pass. After this bug is fixed, you will need to transfer this case to the test_host_header_set_ok test in the same file.
Documentation
https://github.com/tempesta-tech/tempesta/wiki/HTTP-security#:~:text=http_host_required%20%5Btrue%7Cfalse%5D
The text was updated successfully, but these errors were encountered: