Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable proxy #872

Open
skaegi opened this issue Jun 27, 2022 · 5 comments
Open

Option to disable proxy #872

skaegi opened this issue Jun 27, 2022 · 5 comments
Labels
area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@skaegi
Copy link

skaegi commented Jun 27, 2022

We just installed with the operator and noticed that we had several operator-proxy-webhooks running. This is not providing functionality that we want in our cluster and were surprised that the operator installed it. We expected the operator to just help us with managing the lifecycle of our Tekton components and not add functionality.

Could we please have an option to remove it from our config.

@skaegi skaegi added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2022
@vdemeester
Copy link
Member

@skaegi the proxy webhook is basically a no-op, and the admission controller should only be registered if there is a proxy setup (aka the operator having a non-empty http_proxy/… set of environment variables. At least that's how it should work.
This means the operator-proxy-webhooks pod is basically doing nothing, which I think, we could avoid indeed (either smartly or not).

/cc @piyush-garg

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2022
@vdemeester
Copy link
Member

/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 3, 2022
@vdemeester vdemeester added the area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) label Dec 20, 2024
@vdemeester
Copy link
Member

Putting this into the roadmap as it can get in the way under heavy load.
The proxy should be disabled by default if there is no proxy configured.

@vdemeester
Copy link
Member

Also related to #2470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

3 participants