From 4c7bd4dae0053dea675a250726c6bcd0a9dd369f Mon Sep 17 00:00:00 2001 From: Malcolm Landon Date: Mon, 14 Aug 2023 10:17:42 +0200 Subject: [PATCH] feat: increase lambda worker default message retention period (#79) --- lib/lambda-worker/lambda-worker.ts | 2 ++ test/infra/lambda-worker/lambda-worker.test.ts | 2 ++ 2 files changed, 4 insertions(+) diff --git a/lib/lambda-worker/lambda-worker.ts b/lib/lambda-worker/lambda-worker.ts index 24718236..36d83d52 100644 --- a/lib/lambda-worker/lambda-worker.ts +++ b/lib/lambda-worker/lambda-worker.ts @@ -89,6 +89,7 @@ export class LambdaWorker extends cdk.Construct { const lambdaDLQ = new sqs.Queue(this, `${props.name}-dlq`, { queueName: dlqName, visibilityTimeout: queueTimeout, + retentionPeriod: cdk.Duration.days(14), fifo: fifo ? true : undefined, // This is required for fifo, but has to be undefined not flase for non-fifo }); @@ -99,6 +100,7 @@ export class LambdaWorker extends cdk.Construct { const lambdaQueue = new sqs.Queue(this, `${props.name}-queue`, { queueName, visibilityTimeout: queueTimeout, + retentionPeriod: cdk.Duration.days(14), deadLetterQueue: { queue: lambdaDLQ, maxReceiveCount: maxReceiveCount }, fifo: fifo ? true : undefined, // This is required for fifo, but has to be undefined not flase for non-fifo contentBasedDeduplication: diff --git a/test/infra/lambda-worker/lambda-worker.test.ts b/test/infra/lambda-worker/lambda-worker.test.ts index 043a96d7..6c72f816 100644 --- a/test/infra/lambda-worker/lambda-worker.test.ts +++ b/test/infra/lambda-worker/lambda-worker.test.ts @@ -90,6 +90,7 @@ describe("LambdaWorker", () => { haveResourceLike("AWS::SQS::Queue", { QueueName: "MyTestLambdaWorker-queue", VisibilityTimeout: 1500, // 5 (default max receive count) * 300 (lambda timeout) + MessageRetentionPeriod: 1209600, // 14 days RedrivePolicy: { maxReceiveCount: 5, deadLetterTargetArn: { @@ -106,6 +107,7 @@ describe("LambdaWorker", () => { haveResourceLike("AWS::SQS::Queue", { QueueName: "MyTestLambdaWorker-dlq", VisibilityTimeout: 1500, // 5 (default max receive count) * 300 (lambda timeout) + MessageRetentionPeriod: 1209600, // 14 days }) ); });