[Feat] 홈 화면 - 구글 지도, 마이페이지 버튼 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
| **/xcshareddata/WorkspaceSettings.xcsettings | ||
| Config.xcconfig |
There was a problem hiding this comment.
컨피그 파일이 생겼군요! 나중에 공유 부탁드려요!
There was a problem hiding this comment.
네~ gitignore때문에 머지 되면 공유드릴게요!
Comment on lines
24
to
34
| class AppDelegate: NSObject, UIApplicationDelegate { | ||
| func application( | ||
| _ application: UIApplication, | ||
| didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? | ||
| ) -> Bool { | ||
| let apiKey = Bundle.main.infoDictionary?["API_KEY"] as! String | ||
| GMSServices.provideAPIKey(apiKey) | ||
|
|
||
| return true | ||
| } | ||
| } |
There was a problem hiding this comment.
Delegate 파일을 App 폴더에 따로 만들어서 관리하는 것이 좋을 것 같아요!
Comment on lines
31
to
44
| func myPageNavigationLink() -> some View { | ||
| NavigationLink(destination: TempMyPageView()) { | ||
| Image(systemName: "person.circle.fill") | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fit) | ||
| .frame(width: 40, height: 40) | ||
| .background(Color.white) | ||
| .foregroundStyle(.gray3) | ||
| .clipShape(Circle()) | ||
| .overlay { | ||
| Circle().stroke(Color.white, lineWidth: 2) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
저는 이런 경우 Computed Property를 만들어서 관리하는데, Parameter가 따로 없는 경우에는 Computed Property로 만들어서 관리를 하는 것은 어떻게 생각하시나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️ Issue Number
🚩 Summary
1. 지도
Google Maps 사용을 위한 작업
UIViewControllerRepresentable프로토콜을 채택한MapViewControllerBridge를 생성했습니다.(Google Maps SDK는 SwiftUI 호환 뷰를 제공하지 않으며 UIKit을 기반으로 빌드되기 때문)
AppDelegate를 구현했습니다.Google Maps API key 관리
2. 마이페이지 버튼
MyPage 버튼과 연결되는 뷰를 HomeView 파일 안에 임시로 만들었습니다(
TempMyPageView).🙂 To Reviewers
나중에 Mapkit -> GoogleMap으로 변경하면 리소스가 들기에 처음부터 GoogleMap을 사용하는 게 낫다고 판단!
📷 Screenshots