-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-VALIDATION_IDENTIFICATIONQUALIFIER_NOTEMPTY #231
Comments
This feels like do not implement, identificationqualifier would almost always be expected to be empty. The absense of a value does not indicate any data quality issue for anyone. The presence of a value may indicate a data quality issue for some uses. |
The provided example is a citation, not an expected value for dwc:identificationQualifier "A brief phrase or a standard term ("cf.", "aff.") to express the determiner's doubts about the dwc:Identification.", cf., aff. ?, would be plausible examples. |
I tend to agree @chicoreus - but as to the example - a NOTEMPTY test doesn't say it is a valid value - just that it is not empty. |
The term identificationQualifier has various issues and interpretations. I'm not even sure it will ultimately survive in the Darwin Core vocabulary, with something like a identificationFormula (taxonFormula in Arctos) taking it's place. |
I agree with Paul that this feels like do not implement but with John's reasoning that the term has various issues and interpretations (tdwg/dwc#244). |
Agree "DO NOT IMPLEMENT" and Close? |
Suggest, following comments that Darwin Core may not continue with this term, that we just remove all the tags and Close. - i.e. do not have either a Supplementary or DO NOT IMPLEMENT tag. |
@ArthurChapman I do not agree. We should not categorize based on what may or not be. We should do so based on Darwin Core as we know it. |
@tucotuco for the most part, I agree, though we do have the section in the standards document on things we observed that could shape changes to Darwin Core. I would advocate marking this test as Do No Implement as the presence of a value in dwc:identificationQualifier tends to indicate a data quality issue (e.g. something that appears to be known to species isn't actually known to that resolution), the plausible validation would be VALIDATION_IDENTIFICATIONQUALIFIER_EMPTY, which doesn't fit the pattern of the recent set of supplemental tests (driven by thinking about potential alignment with MIDS). |
I guess that in the sense that the test can't really do what it might be expected to do (flag data quality issues) for various reasons, DO NOT IMPLEMENT seems a reasonable label to apply. It also avoids making work we have actually done invisible. |
The text was updated successfully, but these errors were encountered: