Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check permutation overlap/collision #5

Open
tdib opened this issue Aug 16, 2023 · 2 comments
Open

Check permutation overlap/collision #5

tdib opened this issue Aug 16, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@tdib
Copy link
Owner

tdib commented Aug 16, 2023

When queueing multiple moves such as R and L, they are put into a queue, and hence do not happen simultaneously. These moves can happen at the same time as the cubies are entirely unique across both movies, and will not affect one another.

This is primarily an issue with implementations of advanced moves like M, E, and S, which are each implemented using two moves and a rotation.

Screen.Recording.2023-08-16.at.4.53.16.pm.mov
@tdib tdib added the enhancement New feature or request label Aug 16, 2023
@tdib
Copy link
Owner Author

tdib commented Nov 11, 2023

While not exactly addressing this issue, slice/advanced moves are now implemented differently, so this issue is less relevant. In the case of performing L and R moves at the same time, this is still an issue.

I looked into a solution that chunked non-conflicting moves together, and executing those moves all at once, but they did not happen synchronously and caused some strange artefacts.

Screen.Recording.2023-11-11.at.11.37.33.pm.mov

@tdib tdib added the low priority Low priority, not urgent to work on/fix label Nov 11, 2023
@tdib
Copy link
Owner Author

tdib commented Nov 12, 2023

With the implementation of wide moves, this becomes more of an issue :(

Wide moves could be implemented using a different encoding like slice moves were but it would be better to fix this issue directly.

Screen.Recording.2023-11-12.at.11.58.03.am.mov

@tdib tdib removed the low priority Low priority, not urgent to work on/fix label Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant