v1.5.0 TypeError: Invalid URL at Object.e [as resolveUrl]

[JennerChen]

after upgrade to v1.5.0, it may cause crash

TypeError: Invalid URL at Object.e [as resolveUrl] (https://assets.alicdn.com/g/code/npm/@alife/cn-ei-cec-plugin-new-info-view/0.0.18/index.js:1:17315) at a (https://assets.alicdn.com/g/code/npm/@alife/cn-ei-cec-plugin-new-info-view/0.0.18/index.js:1:27376) at e (https://assets.alicdn.com/g/code/npm/@alife/cn-ei-cec-plugin-new-info-view/0.0.18/index.js:1:28269) at e [as addSchema] (https://assets.alicdn.com/g/code/npm/@alife/cn-ei-cec-plugin-new-info-view/0.0.18/index.js:6:107818) at e (https://assets.alicdn.com/g/code/npm/@alife/cn-ei-cec-plugin-new-info-view/0.0.18/index.js:8:63960) at e (https://assets.alicdn.com/g/code/npm/@alife/cn-ei-cec-plugin-new-info-view/0.0.18/index.js:8:63847) at https://assets.alicdn.com/g/code/npm/@alife/cn-ei-cec-plugin-new-info-view/0.0.18/index.js:8:127793 at Bh (https://assets.alicdn.com/g/code/lib/react-dom/16.13.1/umd/react-dom.production.min.js:126:456) at Dj (https://assets.alicdn.com/g/code/lib/react-dom/16.13.1/umd/react-dom.production.min.js:162:476) at unstable_runWithPriority (https://assets.alicdn.com/g/code/lib/react/16.13.1/umd/react.production.min.js:25:260)

[iliapolo]

We are seeing this as well:

More information can be found at: https://a.co/74kJMmI
(Use `node --trace-warnings ...` to show where the warning was created)
TypeError [ERR_INVALID_URL]: Invalid URL
    at new NodeError (node:internal/errors:387:5)
    at URL.onParseError (node:internal/url:565:9)
    at new URL (node:internal/url:641:5)
    at Validator.resolve (/tmp/cdk-integ-0i8alj125w4m/node_modules/@aws-cdk/cloud-assembly-schema/node_modules/jsonschema/lib/validator.js:263:16)
    at Validator.validateSchema (/tmp/cdk-integ-0i8alj125w4m/node_modules/@aws-cdk/cloud-assembly-schema/node_modules/jsonschema/lib/validator.js:194:25)
    at Validator.validate (/tmp/cdk-integ-0i8alj125w4m/node_modules/@aws-cdk/cloud-assembly-schema/node_modules/jsonschema/lib/validator.js:133:21)
    at Function.validate (/tmp/cdk-integ-0i8alj125w4m/node_modules/@aws-cdk/cloud-assembly-schema/lib/manifest.ts:194:30)
    at Function.saveManifest (/tmp/cdk-integ-0i8alj125w4m/node_modules/@aws-cdk/cloud-assembly-schema/lib/manifest.ts:220:14)
    at Function.saveAssemblyManifest (/tmp/cdk-integ-0i8alj125w4m/node_modules/@aws-cdk/cloud-assembly-schema/lib/manifest.ts:74:14)
    at CloudAssemblyBuilder.buildAssembly (/tmp/cdk-integ-0i8alj125w4m/node_modules/aws-cdk-lib/cx-api/lib/cloud-assembly.js:1:6547) {
  input: '/undefined#/definitions/AssemblyManifest',
  code: 'ERR_INVALID_URL'

Note that this is running on node16 - is this an intentional breakage?

[iliapolo]

Also - how come there is no 1.5.0 tag in the repo? this would help identify the relevant commit.

[Hypnosphi]

Same error in Chrome 129. Looks like this expression only works since Chrome 130

new URL('/', 'resolve://')

jsonschema/lib/helpers.js

Line 400 in f65c769

const resolvedUrl = new URL(to, new URL(from, 'resolve://'));

related: #396

@henryrgithub @tdegrunt can you please take a look

[huy97]

"resolutions": {
    "jsonschema": "1.4.1"
  },

I added it to package.json, and it worked for me