Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PerformEval should be modified to use xStr for the rest of the algorithm #21

Closed
fred-wang opened this issue Nov 25, 2024 · 1 comment · Fixed by #22
Closed

PerformEval should be modified to use xStr for the rest of the algorithm #21

fred-wang opened this issue Nov 25, 2024 · 1 comment · Fixed by #22

Comments

@fred-wang
Copy link
Contributor

See https://tc39.es/proposal-dynamic-code-brand-checks/#sec-performeval
We determine a xStr value that we use for HostEnsureCanCompileStrings.

However, the x value is also used at step 11)a) of https://tc39.es/ecma262/#sec-performeval

Let script be ParseText(x, Script).

I assume the intention is to use xStr here too?
@fred-wang
Copy link
Contributor Author

I assume the intention is to use xStr here too?

That's what tc39/ecma262#3294 does, so answer is yes.

fred-wang added a commit to fred-wang/proposal-dynamic-code-brand-checks that referenced this issue Nov 27, 2024
@fred-wang
PerformEval: Also pass xStr to ParseText.
7fd503f 
This aligns with tc39/ecma262#3294

closes tc39#21
fred-wang added a commit to fred-wang/proposal-dynamic-code-brand-checks that referenced this issue Nov 27, 2024
@fred-wang
PerformEval: Also pass xStr to ParseText.
8b02789 
This aligns with tc39/ecma262#3294

closes tc39#21
fred-wang added a commit to fred-wang/proposal-dynamic-code-brand-checks that referenced this issue Nov 27, 2024
@fred-wang
PerformEval: Also pass xStr to ParseText.
a4491ac 
This aligns with tc39/ecma262#3294

closes tc39#21
fred-wang added a commit to fred-wang/proposal-dynamic-code-brand-checks that referenced this issue Nov 27, 2024
@fred-wang
PerformEval: Also pass xStr to ParseText.
5f01504 
This aligns with tc39/ecma262#3294

closes tc39#21
fred-wang added a commit to fred-wang/proposal-dynamic-code-brand-checks that referenced this issue Nov 27, 2024
@fred-wang
PerformEval: Also pass xStr to ParseText.
61cf089 
This aligns with tc39/ecma262#3294

closes tc39#21
@fred-wang fred-wang mentioned this issue Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PerformEval: Also pass xStr to ParseText. fred-wang/proposal-dynamic-code-brand-checks
1 participant
@fred-wang