Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no data decorator still shown if tweets found < count #1

Open
lazymanc opened this issue Dec 19, 2011 · 2 comments
Open

no data decorator still shown if tweets found < count #1

lazymanc opened this issue Dec 19, 2011 · 2 comments

Comments

@lazymanc
Copy link

If a search returns one or more tweets, but less than "count" option then the noDataDecorator is still displayed.

I've used a test account to tweet the random string "oitjghoirjth" exactly twice so it should only return 2 results.

$("#tweets").jTweetsAnywhere({
  searchParams : ["q=oitjghoirjth"],
  count        : 3,
  showTweetFeed: {
    showProfileImages : true,
    showTimestamp     : { refreshInterval: 15 },
    autorefresh       : { mode: "none" },
    paging            : { mode: "more" }
  }
});

What happens is you'll see 2 tweets rendered and then "no more data" from the default decorator.

Expected behaviour would be to only show the no data decorator if no tweets are found at all.

@tbillenstein
Copy link
Owner

Well, I think that is a question of how you define the behavior. Currently it's like: if you want to display 3 tweets at a time and only 2 are available, the 2 tweets are displayed and a hint that there is no more data available. To me that makes sense.

On the other hand your argumentation makes sense also to me.

Maybe best solution would be a configuration option to select the desired behavior

@lazymanc
Copy link
Author

I think originally I had thought it said "no data" rather than "no more data" which is probably why I expected it not to be shown if there were results - I should read the code more carefully :)

I think what I'm after is a "limit" not a "count", but having two similar params might be confusing, so some kind of switch for the behaviour might be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants