Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Efficiency of Semantic Versioning Script #474

Open
Tracked by #430
aatmanvaidya opened this issue Jan 2, 2025 · 0 comments
Open
Tracked by #430

Improve Efficiency of Semantic Versioning Script #474

aatmanvaidya opened this issue Jan 2, 2025 · 0 comments

Comments

@aatmanvaidya
Copy link
Collaborator

aatmanvaidya commented Jan 2, 2025

Feluda has multiple python packages in a single github repo, we could not find any existing tool/GitHub actions that can help us release and do semantic versioning of multiple packages in a monorepo. Hence we had to write our own custom script that does this for us. This is the GitHub action that trigger’s the workflow for semantic versioning - link

Link to the script - link

I think there are some way’s to make this script more efficient, so the task of the issue is do a short spike to explore on way’s to make it efficient. Some possible improvements could be

  • We are opening and loading the pyproject.toml file in multiple function’s - code1 - code2 - code3 - code4. This is a bit error prone and can be handled better.
  • We should also add a function that checks if each pyproject.toml file has a name, version and tag_format
  • We should lint and format the pyproject.toml file better

The changes to the script can be tested in this dummy repo - https://github.com/aatmanvaidya/feluda-versioning-check/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant