fix(job-scheduler): validate if next delayed job exists #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
fix-scheduler-no-add-existing-job
branch
2 times, most recently
from
de2a4b3 to
f251f8b
Compare
roggervalf
force-pushed
the
fix-scheduler-no-add-existing-job
branch
from
94f37ff to
5e9015a
Compare
manast
reviewed
Jan 27, 2025
| removeJob(delayedJobId, true, prefixKey, true --[[remove debounce key]]) | ||
| rcall("ZREM", delayedKey, delayedJobId) | ||
| if rcall("ZSCORE", delayedKey, prevDelayedJobId) ~= false then | ||
| removeJob(prevDelayedJobId, true, prefixKey, true --[[remove debounce key]]) |
There was a problem hiding this comment.
Instead of removing the job here and then adding a new one, couldn't we just set a flag here and if true not add the job again?
There was a problem hiding this comment.
the problem is that if the delayed is not regenerated with new repeat opts, next delayed job will be scheduled with old repeat options. This is happening in that way because we use opts from current delayed job to schedule the next one.
There was a problem hiding this comment.
Ok, can you write a comment then to explain why it is needed so we not need to remember it next time? :)
There was a problem hiding this comment.
sure, I'll add a description about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Enter the implementation details here.
Additional Notes (Optional)
Any extra info here.