Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick example on the home page does not work #3

Closed
ialbert opened this issue Apr 8, 2015 · 1 comment
Closed

Quick example on the home page does not work #3

ialbert opened this issue Apr 8, 2015 · 1 comment

Comments

@ialbert
Copy link

ialbert commented Apr 8, 2015

The quick example on the homepage contains several typos and omissions (six in total!) that make the code unrunnable.

In general, but especially the quick example should be run through python to ensure that it works before pasting it into the docs. It also should be a self sufficient that does not need other information to run.

Since we are here I will make a note that this page does not do a good job in demonstrating what the library actually does. The actually interesting part for me as a python programmer is not that the library can extract the sequences for ensemble proteins - that is a job I can do with many tools already.

What interest me getting to the next level is combining and querying the Ensemble genes and the SNPs at the same time.

But the quick start stops at the most interesting line:

g = Genome(name = "GRCh37.75", SNPs = ["STY21_RNA"], SNPFilter = MyFilter()

ok there is promise here, but now what can I do here once I have this construct? What is MyFilter() what does that do.

@tariqdaouda
Copy link
Owner

Hi,

Sorry about the delay, I missed the notification about the issue.
pyGeno is also intended to be used by people with less technical abilities than you have, and the quick example is there to showcase the package's abilities, hence the simplified first example and the "...". MyFilter() is simply there to signal that you can easily plug your own filter if you need to.

Filters are simple objects that you create by defining classes that inherit from pyGeno.SNPFiltering.SNPFilter. There's an example at the end of the Readme and another one at the end of the quickstart guide in the documentation: http://pygeno.iric.ca/quickstart.html#personalized-genomes.

However I think you're right, I should put more emphasis on the personalized genomes.

tariqdaouda pushed a commit that referenced this issue Jan 9, 2018
Adds translation of mitochondrial proteins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants