-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last interaction radius #1606
Last interaction radius #1606
Conversation
Before a PR is accepted, it must meet the following criteria:
|
1 similar comment
Before a PR is accepted, it must meet the following criteria:
|
It's been a while since this was discussed last, can we get some demo or minimum working example commands or something for how to use it? |
Will this die with packet tracking? @marxwillia can you comment - it also would need to be rebased. |
785e70f
to
907de8d
Compare
We are still interested in this generally. So we are not closing it, in the hopes that one of us (or a student/new contributor) picks it up and completes it |
@jamesgillanders, @wkerzendorf, @marxwillia Can someone from the final year of undergraduate physics work on this? I don't know much about the theory of supernovas except that they are cool ( not in the sense of temperature, of course ). I have taken various Quantum Mechanics, Optics, Relativity, and Computational Physics courses. I am ready to put in the effort. I am fluent in programming in Python. Should I work on this? |
Yes, please make an attempt at the first objective! |
Dear @jamesgillanders , @wkerzendorf , @marxwillia and @andrewfullard My name is Ayush Rai and I am currently pursuing a B.Tech+M.Tech degree in Mathematics and Computational Sciences at IITBHU, Varanasi. I am reaching out to express my interest in contributing to TARDIS through GSoC 2024. I have a passion for open-source development and have some experience in group theory and mathematical modeling. I have also completed internships in creating Python modules and Data analytics. I am proficient in Python and enjoy implementing mathematical theories in other fields. I believe this skill and interest align well with the project. I would be grateful if you could guide me in understanding the codebase by assigning some beginner-friendly tasks. Additionally, I would like to connect with mentors and other community members. Thank you for your time and consideration. Best regards, |
Ayush, we have step-by-step instructions here https://tardis-sn.github.io/summer_of_code/gsoc_home/ |
Closing this PR. A revised implementation that works with the restructured codebase is being developed as part of GSoC 2024. |
Description
Adding a new visualization tool which allows the user to see the location of the last line interaction of all packets in their TARDIS simulation. This allows the user to see exactly where in the ejecta certain lines transitions are predominantly occurring. This information can be used to adjust models to better fit observations.
Motivation and context
This new tool will allow users to better understand their models and fit to observed data more easily.
How has this been tested?
Examples
Below is an example plot showing the location distributions for a variety of elements/ions. This new tool will implement both matplotlib and plotly versions.
Type of change
Checklist