Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve object comparison (deepEqual) #7

Open
tjconcept opened this issue Oct 22, 2016 · 4 comments
Open

Improve object comparison (deepEqual) #7

tjconcept opened this issue Oct 22, 2016 · 4 comments

Comments

@tjconcept
Copy link

  (anonymous)
    ✖ should be equivalent
      at Test.<anonymous> (...)

      <green>actual</green> <red>expected</red>

      { a: <red>fals</red><green>tru</green>e, b: false }

I think the output for objects that are not equal has potential for being improved.

It would be nice with something more like:

{
  a: true,   // actual
  a: false,  // expected

  b: false,
}
@scottcorgan
Copy link
Member

@tjconcept checkout https://github.com/tap-format/spec and see if that has better formatting for. It's the successor to this library and, in my opinion, is much nicer.

Let me know.

@tjconcept
Copy link
Author

@scottcorgan you linked me to this very same repository?

@scottcorgan
Copy link
Member

Ha, whoops. I was so used to tap-spec getting issues like this.

I agree the object output could be better then. I'd love to see any ideas you might have as far is implementation.

@tjconcept
Copy link
Author

I sadly don't have the time currently, but I'll leave it here if someone pops by and wants to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants