Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore function signatures in code coverage report, while not ignore function bodies? #328

Closed
fzyzcjy opened this issue Dec 22, 2023 · 2 comments

Comments

@fzyzcjy
Copy link

fzyzcjy commented Dec 22, 2023

Given #327, one work around may be, if we can somehow ignore the function signatures, while keeping the function bodies un-ignored. However, I am not sure whether this is possible currently.

For implementation, one naive way may be:

  • Users add comments such as // coverage_off_begin and // coverage_off_end (like in other langauges)
  • Adding a post-processing script, which inputs LCOV report (or whatever), parse the source code, sees (e.g.) line 10-15 is marked ignored by that comment, then change LCOV report by removing those lines.
@taiki-e
Copy link
Owner

taiki-e commented Dec 23, 2023

I prefer to fix the bug itself rather than add an odd workaround to avoid the odd bug.

@taiki-e taiki-e closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2023
@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 23, 2023

Totally agree!

Btw I already add workarounds in https://github.com/fzyzcjy/flutter_rust_bridge ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants