-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari 14 support. #64
Labels
Comments
https://github.com/chrisguttandin/standardized-audio-context Maybe this can help? |
Fixed by #71 , I can do separate PR if needed
|
Fixing createConstantSource and moving canvas creation to start did the trick. |
Fixed in 4.0.0 release. |
@stijndeschuymer Please close this issue if it is solved in 4.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, Thanks for your great library. I noticed the following:
This line fails in Safari 14: https://github.com/t-mullen/video-stream-merger/blame/cf54b5fe3bc4f5624d719b064874e615757c8a12/src/index.js#L61
So either this needs to be added to the audioSupport check https://github.com/t-mullen/video-stream-merger/blob/gh-pages/src/index.js#L11
But I'd prefer to fix this _backgroundAudioHack function.
maybe createConstantSource() could be replaced by AudioContext.createOscillator() ?
Wdyt?
Thanks!
The text was updated successfully, but these errors were encountered: