Skip to content

Commit

Permalink
fix generate-code caching by indicating that the binary is an executable
Browse files Browse the repository at this point in the history
Pull Request resolved: pytorch#79625

Per Josiah Gaskin's followup on
https://www.internalfb.com/intern/qa/365579, using $(exe ...) instead
of $(location ...) should address the caching behavior.

@override-unit-failures
(Note: this ignores all push blocking failures!)

Differential Revision: [D36970846](https://our.internmc.facebook.com/intern/diff/D36970846/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36970846/)!

Approved by: https://github.com/malfet
  • Loading branch information
Michael Andreas Dagitses authored and pytorchmergebot committed Jun 16, 2022
1 parent 18fcd48 commit 86606fb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def define_targets(rules):
],
tools = ["//tools/setup_helpers:generate_code"],
outs = GENERATED_AUTOGRAD_CPP + GENERATED_AUTOGRAD_PYTHON + GENERATED_TESTING_PY,
cmd = "$(location //tools/setup_helpers:generate_code) " +
cmd = "$(execpath //tools/setup_helpers:generate_code) " +
"--gen-dir=$(RULEDIR) " +
"--native-functions-path $(location :native_functions.yaml) " +
"--tags-path=$(location :tags.yaml) " +
Expand Down

0 comments on commit 86606fb

Please sign in to comment.