Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE]: Use multiple excludedFieldsConfigs in the RemoteSyncer #49

Open
damsien opened this issue Dec 23, 2024 · 1 comment
Open

[FE]: Use multiple excludedFieldsConfigs in the RemoteSyncer #49

damsien opened this issue Dec 23, 2024 · 1 comment
Labels
blocked When an issue is blocked or depends an another one enhancement Request for enhancement

Comments

@damsien
Copy link
Collaborator

damsien commented Dec 23, 2024

Roadmap 2025/02 Use multiple excludedFieldsConfigs in the RemoteSyncer.
As the Platform Engineer of my team, I want to set multiple excludedFields ConfigMaps in my RemoteSyncer.

What to do

1. Change the specs to have a list of ConfigMaps instead of only one ConfigMap

Change the type to a list of corev1.ObjectReference.

ExcludedFieldsConfigMapRef *corev1.ObjectReference `json:"excludedFieldsConfig,omitempty" protobuf:"bytes,opt,8,name=excludedFieldsConfig"` // Ref to a ConfigMap

2. Loop over each ConfigMaps

Add a for loop before the check of each ConfigMaps.

// Check if the excludedFields ConfigMap exists
if wrc.remoteSyncer.Spec.ExcludedFieldsConfigMapRef != nil && wrc.remoteSyncer.Spec.ExcludedFieldsConfigMapRef.Name != "" {

The concerned function is built in this issue: #47.

wrc.getPathsFromConfigMap(wrc.remoteSyncer)

3. Get the values depending on the key

Search for the excludedFields key. If it does not exists, then add a condition to the status specifying that the key is not found for this ConfigMap.

Additional context

If you have any questions, please tag @damsien.

@damsien damsien added the enhancement Request for enhancement label Dec 23, 2024
@damsien damsien added the blocked When an issue is blocked or depends an another one label Jan 2, 2025
@damsien
Copy link
Collaborator Author

damsien commented Jan 2, 2025

Blocked by #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked When an issue is blocked or depends an another one enhancement Request for enhancement
Projects
None yet
Development

No branches or pull requests

1 participant