Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 SynRadioGroup: SynRadio elements not clickable when they have no value while using form validation #661

Closed
3 of 5 tasks
schilchSICKAG opened this issue Oct 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@schilchSICKAG
Copy link
Contributor

Checklist (for the issue creator)

  • I have verified the bug exists in the latest version of @synergy-design-system/components (e.g. via pnpm install @synergy-design-system/components).
  • I can provide a simple, reproducible example of the issue (e.g. via code-sandbox or sample code, ...).
  • I would be willing to provide a PR for this issue.

Version

The bug occurred with the following version of the component library: Any

Component

The issue arises when using the following component(s): syn-radio-group, syn-radio

Environment

The issue occurred with the following operating system(s): All
The issue occurred in the following browser(s): All

Description

When using an <syn-radio-group> with required set to true, it is not possible to select <syn-radio> elements that do not have a value property set when clicking on the item the first time.

This can be seen at https://codepen.io/schilchSICKAG/pen/JjgOxyv?editors=1000 in Shoelace. I also created a Shoelace Issue for this at shoelace-style/shoelace#2229.

Acceptance criteria

  • All DoD items successfully completed
  • <syn-radio> elements should be clickable when there is no value set and required is set to true.
@klaarseSICKAG klaarseSICKAG added the bug Something isn't working label Nov 21, 2024
@klaarseSICKAG
Copy link
Contributor

please ping shoelace devs again

@klaarseSICKAG klaarseSICKAG moved this from 🆕 New to 📋 To be Refined in Synergy Backlog Nov 21, 2024
@klaarseSICKAG
Copy link
Contributor

no stakeholder feedback yet. reopen if necessary

@klaarseSICKAG klaarseSICKAG closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
@github-project-automation github-project-automation bot moved this from 📋 To be Refined to ✅ Done in Synergy Backlog Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants