Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"distribute" confirmation screen #1932

Closed
dpc22 opened this issue Jan 23, 2025 · 2 comments · Fixed by #1933
Closed

"distribute" confirmation screen #1932

dpc22 opened this issue Jan 23, 2025 · 2 comments · Fixed by #1933
Labels

Comments

@dpc22
Copy link
Contributor

dpc22 commented Jan 23, 2025

Version

6.2.74

Installation method

My own rpm, derived from the "official" RHEL 9 rpm for 6.2.74.

Expected behavior

If I attempt to distribute messages held for moderation on the Sympa modindex screen I see a confirmation screen which says:

"Distribute

Please select one or more topic(s) that corresponds to the messages you wish to distribute:"

I would expect this text to say something else if no topics are defined on the Sympa server.

Actual behavior

The confirmation screen shows the precise text above without a list of topics which can be selected (as none are defined)

There are "Confirm" and "Back" buttons which work despite the lack of any topics to select.

I can't remember if 6.2.72 works the same way, and wwsympa refuses to start if I try to downgrade Sympa on my test system.

Steps to reproduce

Generate a few messages in the moderation queue on a list and click "Distribute selected messages" after selecting them on the modindex screen

Additional information

First mentioned as an aside on #1926

@ikedas
Copy link
Member

ikedas commented Jan 25, 2025

Hi @dpc22 ,

Could you please check this patch?

@ikedas ikedas modified the milestone: 6.2.76 Jan 25, 2025
@dpc22
Copy link
Contributor Author

dpc22 commented Jan 27, 2025

Yes, that seems to have done the trick. Thank you.

ikedas added a commit that referenced this issue Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants