Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Revert doc change about final class generation #1636

Open
MrYamous opened this issue Dec 31, 2024 · 0 comments
Open

[Docs] Revert doc change about final class generation #1636

MrYamous opened this issue Dec 31, 2024 · 0 comments

Comments

@MrYamous
Copy link
Contributor

MrYamous commented Dec 31, 2024

While reading documentation about this bundle, i've found this in configuration section

By default, MakerBundle will generate all of your classes with the final PHP keyword except for doctrine entities. Set this to false to override this behavior for all maker commands.

I think this new configuration is a good idea, but in current state, this sentence looks wrong to me. Some classes such WebhookConsumer or RequestParser are always generated as final and some others, TwigExtension or EventSubscriber are never

This could lead to a kind of strange state with this configuration available without being functional everywhere (as is already the case) but at the moment I feel like the documentation is misleading on this specific point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant