Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Practice Session #12 Code Smell #120

Open
Junetrbl opened this issue Nov 25, 2021 · 3 comments
Open

Practice Session #12 Code Smell #120

Junetrbl opened this issue Nov 25, 2021 · 3 comments

Comments

@Junetrbl
Copy link
Contributor

❓ <AS-IS> What is this issue for?

  • To diagnose code smells in our repository and to improve our codes by mitigating them
@Junetrbl
Copy link
Contributor Author

Junetrbl commented Nov 25, 2021 •
edited by mieseung
Loading

Pull request #121

Code smell : Duplicate codes for checking whether user is logged in
Solution : Add a decorator for checking whether user is logged in

@ericagong
Copy link
Contributor

ericagong commented Nov 26, 2021 •
edited by mieseung
Loading

Pull request #125

(1)
Code smell : Duplicate codes for rendering rank, champion, lane images
Solution : Clean code with JS template string

(2)
Code smell : Duplicate codes between parent component and child component
Solution : Delete unnecessary parent component

@Xena123kiki
Copy link
Contributor

Xena123kiki commented Nov 26, 2021 •
edited
Loading

Pull request #107

Code Smell : Inappropriate use of CSS components
Solution : Change use of CSS components

@mieseung mieseung pinned this issue Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Xena123kiki @ericagong @Junetrbl