-
Notifications
You must be signed in to change notification settings - Fork 7
Comparing changes
Open a pull request
base repository: F5Networks/f5-openstack-heat-plugins
base: kilo
head repository: swormke/f5-openstack-heat-plugins
compare: kilo
- 19 commits
- 37 files changed
- 4 contributors
Commits on Feb 17, 2016
-
Problem: Deploy iApp template and service with Heat Analysis: The template is deployed first, and the service depends upon the template. The service executes the template script and creates a virtual server, a pool, and several pool members. Unit/Robot tests: We need a testing structure for Heat resources. That is captured in OPENSTACK-117 and OPENSTACK-118
Paul Breaux committedFeb 17, 2016 Configuration menu - View commit details
-
Copy full SHA for 9cd4384 - Browse repository at this point
Copy the full SHA 9cd4384View commit details -
Problem: Need to add heat yaml file with real IPs to test. Analysis: Added yaml file with real IPs in the iapp template. Unit/Robot tests:
Paul Breaux committedFeb 17, 2016 Configuration menu - View commit details
-
Copy full SHA for 28c35ed - Browse repository at this point
Copy the full SHA 28c35edView commit details -
Problem: Update copyright on all files in this repo Analysis: The copyright should be 2015-2016, and it has been updated to reflect this. Unit/Robot tests:
Paul Breaux committedFeb 17, 2016 Configuration menu - View commit details
-
Copy full SHA for 06eb60a - Browse repository at this point
Copy the full SHA 06eb60aView commit details -
Problem: Authentication to the BigIP for each Heat plugin should not be necessary Analysis: Added bigip_server property to each plugin. These reference the new f5_bigip resource, which simply houses the ip, username, and password to access the bigip device. Unit/Robot tests:
Paul Breaux committedFeb 17, 2016 Configuration menu - View commit details
-
Copy full SHA for 0f943cd - Browse repository at this point
Copy the full SHA 0f943cdView commit details -
Problem: Add unit tests for refactored plugin code Analysis: Added unit tests for existing plugins and for the new plugin, f5_bigip. Unit/Robot tests: All tests passed with %100 statement coverage
Paul Breaux committedFeb 17, 2016 Configuration menu - View commit details
-
Copy full SHA for c1b70bf - Browse repository at this point
Copy the full SHA c1b70bfView commit details -
Problem: Plugins need to be created for load-balancing scenario Analysis: Adding common directory for access to f5_bigip_connection class, so all plugins can subclass this and get a connection to the bigip when need, instead of each class having to have the same function. Unit/Robot tests:
Paul Breaux committedFeb 17, 2016 Configuration menu - View commit details
-
Copy full SHA for 42f7025 - Browse repository at this point
Copy the full SHA 42f7025View commit details -
Problem: Call to BigIP resource in virtual server does not use proper named parameters Analysis: Change the create call in the virtual server plugin to use the correct properties for each named parameter. Unit/Robot tests:
Paul Breaux committedFeb 17, 2016 Configuration menu - View commit details
-
Copy full SHA for f6e3c5d - Browse repository at this point
Copy the full SHA f6e3c5dView commit details -
Problem: Create plugins (Virtual Server, Pool, Real Servers) for controlling the BigIP without an iApp Analysis: Created plugins for virtual_server and pool (which includes real servers) and unit tested each Unit/Robot tests: Produces 100% statement coverage
Paul Breaux committedFeb 17, 2016 Configuration menu - View commit details
-
Copy full SHA for 9197f62 - Browse repository at this point
Copy the full SHA 9197f62View commit details -
Problem: Integrate this repo with Travis CI Analysis: Added a .travis.yml file. Testing build. Unit/Robot tests: All tests passing
Paul Breaux committedFeb 17, 2016 Configuration menu - View commit details
-
Copy full SHA for 562b70d - Browse repository at this point
Copy the full SHA 562b70dView commit details -
Problem: Allow iapp answers upload with iapp template Analysis: iAppService plugin has been modified to accept the answers in the template or as an included file. Tests have also been written for this extension to the plugin. Unit/Robot tests: All tests passing
Paul Breaux committedFeb 17, 2016 Configuration menu - View commit details
-
Copy full SHA for 0145c6a - Browse repository at this point
Copy the full SHA 0145c6aView commit details
Commits on Feb 18, 2016
-
Extend f5_sys_iapp_template plugin to allow full iapp template upload
Fixes: Issue #34 Problem: The template above needs to be extended to allow a full iapp template to be uploaded to the BigIP. Analysis: This the first step in that process. The plugin has been extended to now have a composite template and a full template property that a use can define in their heat templates. Note: the two properties are mutually exclusive. Unit/Robot tests: No tests run yet
Paul Breaux committedFeb 18, 2016 Configuration menu - View commit details
-
Copy full SHA for 8c1e104 - Browse repository at this point
Copy the full SHA 8c1e104View commit details -
Addressing code review comments for PR #35
Fixes: PR #35 Problem: The get_partition_name method in the mixins module is poorly named and uses dubious decision logic to account for a default 'Common' partition. This should be made easier to read and more efficient. Analysis: Modified all plugins to now require the partition. Refactored the mixins method to simply return the partition name from the partition resource in the stack. This boils down to having a partition resource even if it is the default of 'Common'. The trick there is that we do not try to recreate 'Common' partition from Heat, as it already exists on the BigIP in all known cases. It simply creates a resource object for that partition even if that partition is not going to be created on teh BigIP device. Unit/Robot tests: All tests passed. 100% code coverage and 100% coverage across all plugin code.
Paul Breaux committedFeb 18, 2016 Configuration menu - View commit details
-
Copy full SHA for eee42cf - Browse repository at this point
Copy the full SHA eee42cfView commit details -
Addressing last review comments from @zancas for pull request
Fixes: PR #35 Problem: Plugin code needs a little tweaks for readability Analysis: Changed a line break in the mixins and a var name in iappservice Unit/Robot tests: All tests pass
Paul Breaux committedFeb 18, 2016 Configuration menu - View commit details
-
Copy full SHA for c1c3dd1 - Browse repository at this point
Copy the full SHA c1c3dd1View commit details -
Merge pull request #35 from pjbreaux/feature.full_template_upload
Feature.full template upload
Configuration menu - View commit details
-
Copy full SHA for d72d949 - Browse repository at this point
Copy the full SHA d72d949View commit details
Commits on Feb 19, 2016
-
Adds usage example of heat plugins
Fixes: Issue #28 Problem: Need a usage example in the docs and README in this repo Analysis: Added a basic usage example in README.rst and docs/index.rst to demonstrate how to create and configure an object on the BigIP VE. It also highlights the minimum requirements to accomplish this. Unit/Robot tests:
Paul Breaux committedFeb 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 3bcbe38 - Browse repository at this point
Copy the full SHA 3bcbe38View commit details -
Merge pull request #39 from pjbreaux/feature.add_usage_doc_2
Adds usage example of heat plugins
Configuration menu - View commit details
-
Copy full SHA for c0826d9 - Browse repository at this point
Copy the full SHA c0826d9View commit details -
Add files and info to make repo public #31
Issues: Fixes #31 Problem: Need to ensure the right files and data is in the repo in order to make it public. Analysis: * Updated README and doc files * Removed the SLACK tokens from the .travis.yml file * Added f5-sdk to the requirements.*.txt files Tests: * Tested that f5-sdk was installed by requirements.txt * Compiled the docs
Configuration menu - View commit details
-
Copy full SHA for 27c2c2a - Browse repository at this point
Copy the full SHA 27c2c2aView commit details
Commits on Feb 21, 2016
-
Add files and info to make repo public
Issues: Fixes #29 Module is pip installable Fixes #30 Docs are available on Read the Docs WIP #31 Add files and info to make repo public Problem: The repo needs to be public now that the f5-sdk is available. Analysis: * Added required files * Added deploy section to travis config file to upload to pypi * Created a setup.py to build the python package Tests: * Built and installed the package * Will test further on public systems.
Configuration menu - View commit details
-
Copy full SHA for e5fb6bf - Browse repository at this point
Copy the full SHA e5fb6bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 495686e - Browse repository at this point
Copy the full SHA 495686eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff kilo...kilo