Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing build number from release asset #433

Open
fenhl opened this issue Feb 27, 2025 · 4 comments
Open

Consider removing build number from release asset #433

fenhl opened this issue Feb 27, 2025 · 4 comments

Comments

@fenhl
Copy link
Contributor

fenhl commented Feb 27, 2025

I'm trying to get SwiftBar updated in Homebrew and ran into 2 issues:

  1. The method recommended by the contributing guide to update a cask, brew bump --open-pr swiftbar, didn't work because it was looking for the release asset with build number b520 from 2.0.0, while 2.0.1 uses b536, so I had to create the PR manually.
  2. One of the required verification steps, brew audit --cask --online swiftbar, fails for presumably the same reason.

If the build number were removed from the filename, that would make automation tasks like this easier to set up.

@melonamin
Copy link
Contributor

You are saying that having a stable SwiftBar.zip will help to address this issue?

@fenhl
Copy link
Contributor Author

fenhl commented Feb 27, 2025

SwiftBar.v2.0.1.zip, without the b536 part, should also be fine. The version number is already required to build the full URL after all.

@melonamin
Copy link
Contributor

Updated in the latest release, so you can give it a try.

I would need to update the Sparkle thingy, but that shouldn't be too much work.

fenhl added a commit to fenhl/homebrew-cask that referenced this issue Feb 27, 2025
@fenhl
Copy link
Contributor Author

fenhl commented Feb 27, 2025

Thanks, I can't test it anymore because the PR already exists now, but we'll know for sure on the next release after 2.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants