Skip to content
This repository has been archived by the owner on Apr 13, 2021. It is now read-only.

Inconsistent save_samples and load_samples definition in peregrine.samples #8

Open
sudiptakarmakar opened this issue Oct 12, 2015 · 1 comment

Comments

@sudiptakarmakar
Copy link

The declaration for save_samples is
def save_samples(filename, samples, file_format='int8')

and declaration for load_samples is
def load_samples(filename, num_samples=-1, num_skip=0, file_format='piksi')

Because of that, passing minimum number or arguments, if you save a sample it saves in np.int8 format, but when loading, it tries to retrieve that saved sample in piksi format. As a result, returned object is often starkly different from what was saved at first.

@henryhallam
Copy link
Contributor

Thanks, indeed we should make that consistent. I'm planning to merge a lot of updates into the master branch of peregrine soon, and will address this.

Paakkit pushed a commit to Paakkit/peregrine that referenced this issue Mar 14, 2016
…encoding

iqgen: fixed bug with 2 bit encoding
pmiettinen pushed a commit to pmiettinen/peregrine that referenced this issue Apr 22, 2016
…gps-msg

iqgen: unit tests for common and GPS message types
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants