Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme request: MDC theme #41

Closed
maicol07 opened this issue Nov 24, 2019 · 6 comments
Closed

Theme request: MDC theme #41

maicol07 opened this issue Nov 24, 2019 · 6 comments

Comments

@maicol07
Copy link

Hi,
is it possible to get a SweetAlert2 theme using MDC?
Reference: https://material.io/develop/web/
Thanks

@gverni
Copy link
Contributor

gverni commented Nov 27, 2019

Hi @maicol07 do you mean a material-ui theme? That is already available.

@maicol07
Copy link
Author

MDC has a different style than Material UI

@gverni
Copy link
Contributor

gverni commented Nov 27, 2019

Would you care for elaborating on exactly what’s your request @maicol07? Material-ui and MDC are two implementations of the material design guidelines, so they are visually very similar. Since i’m not a designer, can you explain what would you change in the Sweetalert2 material-ui theme appearance to make it MDC?

@maicol07
Copy link
Author

@gverni ripples on buttons (more rounded), inputs like MD specs ones

@gverni
Copy link
Contributor

gverni commented Nov 28, 2019

I agree on the ripple @maicol07 because this is actually defined in the MD guidelines. I can try to add it to the material-ui theme if it's not overcomplicating the SCSS. For what concern the input, as you know MD guidelines provide different types of inputs, and we decided to go for the Text Field without label one. We are limited in only using CSS for theming, so we may not be able to implement all of the effects for all of the inputs.

@gverni
Copy link
Contributor

gverni commented Dec 1, 2019

Closed in favor of #42

@gverni gverni closed this as completed Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants