From a736204b6f7ed30c9079aa0187b1e46fac6bb9b8 Mon Sep 17 00:00:00 2001 From: Limon Monte Date: Wed, 19 May 2021 10:30:55 +0300 Subject: [PATCH] fix: drop legacy hooks --- .github/workflows/ci.yml | 2 +- src/index.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cb5e9b9..034671a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v2 - name: Install npm dependencies run: yarn install diff --git a/src/index.js b/src/index.js index cfe4825..d16f394 100644 --- a/src/index.js +++ b/src/index.js @@ -31,7 +31,7 @@ export default function withReactContent (ParentSwal) { let domElement - const openHookName = params.onOpen || !ParentSwal.isValidParameter('didOpen') ? 'onOpen' : 'didOpen' // support legacy onOpen hook + const openHookName = 'didOpen' const superOpenHook = params[openHookName] || noop params[openHookName] = (element) => { domElement = getter(ParentSwal) @@ -39,7 +39,7 @@ export default function withReactContent (ParentSwal) { superOpenHook(element) } - const destroyHookName = params.onDestroy || !ParentSwal.isValidParameter('didDestroy') ? 'onDestroy' : 'didDestroy' // support legacy onDestroy hook + const destroyHookName = 'didDestroy' const superDestroyHook = params[destroyHookName] || noop params[destroyHookName] = (element) => { superDestroyHook(element)