Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTORING #135

Open
swarooppatilx opened this issue Oct 12, 2024 · 4 comments
Open

REFACTORING #135

swarooppatilx opened this issue Oct 12, 2024 · 4 comments
Assignees
Labels
gssoc-ext GirlScript Summer of Code Extended 2024 hacktoberfest-accepted Hacktoberfest level2 GirlScript Summer of Code Level 2 Issue

Comments

@swarooppatilx
Copy link
Owner

This is a serious issue,
I noticed many PRs are applying custom css which is inconsistent with the website theme.
I think its time we decide to have a global css with styles that are applied to whole website.

Not just css, the whole structure needs to be redesigned with DRY principles and modular approach in mind.

app.js file does more things than it needs to. we have to seperate the routes, database logic from app.js

I will be accepting PRs of refactoring code with level 1 or level 2 depending on the complexity.

Be sure not to break existing code, test it throughly.

@swarooppatilx swarooppatilx added gssoc-ext GirlScript Summer of Code Extended 2024 hacktoberfest-accepted Hacktoberfest labels Oct 12, 2024
@sayiamarora
Copy link
Contributor

Hey @swarooppatilx ........
Can you provide with me more details and requirements for this issue.

@swarooppatilx
Copy link
Owner Author

@sayiamarora you can do any of the above mentioned tasks like seperating routing and database logic from app.js

or creating global styles and apply the same instead of putting everything inside head.ejs

@rishabh7923
Copy link
Contributor

I’m confident that I can add a professional touch to code, organizing everything in a clear and intuitive way so that other developers can easily navigate and work with it.

To be precise, I want to work on this first.

app.js file does more things than it needs to. we have to seperate the routes, database logic from app.js

@swarooppatilx swarooppatilx added the level2 GirlScript Summer of Code Level 2 Issue label Oct 16, 2024
@sayiamarora
Copy link
Contributor

Hey @swarooppatilx Check my PR #181. I have Refactored it completely and make the App.js file look cleaner and more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GirlScript Summer of Code Extended 2024 hacktoberfest-accepted Hacktoberfest level2 GirlScript Summer of Code Level 2 Issue
Projects
None yet
Development

No branches or pull requests

3 participants