From 922228bfebc6f41bcf2674770bdfaac7c833eaa7 Mon Sep 17 00:00:00 2001 From: Steven Swartz Date: Sun, 28 May 2023 16:03:27 -0400 Subject: [PATCH] v1.5.1 fixes bug loading settings on new installs (#66) Co-authored-by: Steven Swartz --- manifest-beta.json | 2 +- manifest.json | 2 +- package.json | 2 +- src/domain/initiatePluginSettings.test.ts | 6 ++++++ src/domain/initiatePluginSettings.ts | 5 ++++- versions.json | 3 ++- 6 files changed, 15 insertions(+), 5 deletions(-) diff --git a/manifest-beta.json b/manifest-beta.json index f0129272b..1526b7d62 100644 --- a/manifest-beta.json +++ b/manifest-beta.json @@ -1,7 +1,7 @@ { "id": "obsidian-plugin-update-tracker", "name": "Plugin Update Tracker", - "version": "1.5.0", + "version": "1.5.1", "minAppVersion": "0.15.0", "description": "Know when installed plugins have updates and evaluate the risk of upgrading", "author": "Obsidian", diff --git a/manifest.json b/manifest.json index f0129272b..1526b7d62 100644 --- a/manifest.json +++ b/manifest.json @@ -1,7 +1,7 @@ { "id": "obsidian-plugin-update-tracker", "name": "Plugin Update Tracker", - "version": "1.5.0", + "version": "1.5.1", "minAppVersion": "0.15.0", "description": "Know when installed plugins have updates and evaluate the risk of upgrading", "author": "Obsidian", diff --git a/package.json b/package.json index b27f352fa..8b03eb729 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "obsidian-plugin-update-tracker", - "version": "1.5.0", + "version": "1.5.1", "description": "Know when installed plugins have updates and evaluate the risk of upgrading", "main": "main.js", "scripts": { diff --git a/src/domain/initiatePluginSettings.test.ts b/src/domain/initiatePluginSettings.test.ts index 3af26da94..a24d665c8 100644 --- a/src/domain/initiatePluginSettings.test.ts +++ b/src/domain/initiatePluginSettings.test.ts @@ -2,6 +2,12 @@ import initiatePluginSettings from './initiatePluginSettings'; import { DEFAULT_PLUGIN_SETTINGS, PluginSettings } from './pluginSettings'; describe('initiatePluginSettings', () => { + test('loading plugin for first time with null existing settings uses default settings', () => { + const settings = initiatePluginSettings(null); + + expect(settings).toEqual(DEFAULT_PLUGIN_SETTINGS); + }); + test('loading plugin for first time uses default settings', () => { const settings = initiatePluginSettings({}); diff --git a/src/domain/initiatePluginSettings.ts b/src/domain/initiatePluginSettings.ts index 8bbbc04b5..d1f557343 100644 --- a/src/domain/initiatePluginSettings.ts +++ b/src/domain/initiatePluginSettings.ts @@ -1,6 +1,9 @@ import { DEFAULT_PLUGIN_SETTINGS, PluginSettings } from './pluginSettings'; -export default function initiateSettings(savedSettings: Partial): PluginSettings { +export default function initiateSettings( + savedSettings: Partial | null +): PluginSettings { + savedSettings = savedSettings || {}; const migratedSettings: Partial = {}; if ( diff --git a/versions.json b/versions.json index cf14024f9..890cde1ba 100644 --- a/versions.json +++ b/versions.json @@ -15,5 +15,6 @@ "1.4.4": "0.15.0", "1.4.5": "0.15.0", "1.4.6": "0.15.0", - "1.5.0": "0.15.0" + "1.5.0": "0.15.0", + "1.5.1": "0.15.0" }