Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open hub with promise from IPFS #26

Open
svub opened this issue Nov 27, 2019 · 0 comments
Open

Open hub with promise from IPFS #26

svub opened this issue Nov 27, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@svub
Copy link
Owner

svub commented Nov 27, 2019

Nimiq Hub can take as parameter a promise, so, it's possible to push the order to IPFS and instead of waiting, calling the Hub directly with a Promise that resolves when IPFS returns the file hash. This way, Nimiq Checkout can start syncing while we wait for the hash from IPFS.

Besides being nice enhancement, if IPFS takes long, the browser will refuse to open the window (300ms limit for user interaction handlers!) - so this fix will avoid such an edge case by opening the window right away.

@svub svub added the enhancement New feature or request label Nov 28, 2019
@svub svub added this to the v2.0 milestone Nov 28, 2019
@svub svub added the good first issue Good for newcomers label Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant