Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt plan files #2217

Open
suzuki-shunsuke opened this issue Jan 6, 2025 · 0 comments
Open

Encrypt plan files #2217

suzuki-shunsuke opened this issue Jan 6, 2025 · 0 comments
Labels
enhancement New feature or request security

Comments

@suzuki-shunsuke
Copy link
Owner

Feature Overview

We stored plan files in GitHub Artifacts.

https://suzuki-shunsuke.github.io/tfaction/docs/feature/plan-file

This issue suggests to encrypt plan files somehow.
There would be some options for encryption.

Why is the feature needed?

We stored plan files in GitHub Artifacts.

https://suzuki-shunsuke.github.io/tfaction/docs/feature/plan-file

We migrated the storage from S3 or GCS to GitHub Artifacts to prevent plan files from being tampered.
But people with the read permission of the repository can access plan files.
If plan files include secret, this is security issue.
Of course, you should not store secrets in plan files basically, but the security incident can occur.
And attackers can leak secrets to plan files.

Example Code

No response

Note

Even if we encrypt plan files, attackers can decrypt them via CI.

@suzuki-shunsuke suzuki-shunsuke added enhancement New feature or request security labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security
Projects
None yet
Development

No branches or pull requests

1 participant