Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that client config merging is working #114

Open
spkane opened this issue Feb 9, 2022 · 3 comments
Open

Verify that client config merging is working #114

spkane opened this issue Feb 9, 2022 · 3 comments
Labels
bug Something isn't working next Higher priority issues

Comments

@spkane
Copy link
Contributor

spkane commented Feb 9, 2022

Some testing appears to suggest that the merging of a client config in the local directory (for something like a git repo) is not currently working.

Verify this and fix it if required.

In all actuality we should walk up the filesystem looking for the first config that we find, to merge with the primary config file (or use if no primary is found)

@spkane spkane added the bug Something isn't working label Feb 9, 2022
@spkane
Copy link
Contributor Author

spkane commented Feb 9, 2022

Basically, If I have a cludo.yaml in the current directory, it should be merged with my normal cludo.yaml so that a local directory can primarily override the target.

@spkane spkane added the next Higher priority issues label Feb 9, 2022
@goonzoid
Copy link

goonzoid commented Feb 10, 2022

Yeah, looks like this is currently broken.

A couple of thoughts / questions:

  • Do we want to support a case where the client user only has a single config file in their local directory?
  • What is the correct order of precedence for the other locations that the "normal" config file should be found?

@goonzoid
Copy link

Also just noticed #103 which is related. Going to take a step back and see if I can document the expected behaviour with regards to all things config related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next Higher priority issues
Projects
None yet
Development

No branches or pull requests

2 participants