You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're logging to two places Logger() and fmt.Printf() - are they going to the same place (stdout)? If so, why use two separate calls.
Also, many of our error messages are focused on the implementation ("Failed to initialize dohicky") instead of the impact ("Failed to connect to google.com").
standardize logging system
review error messages, rewriting them for the user's consumption.
The text was updated successfully, but these errors were encountered:
This has been cleaned up a bit, and at the moment:
api.Logger() is used in the configureAPI() - Note: This is simply log.Printf() log.Printf() is used elsewhere. fmt.Print() style commands are only used in cludo client for STDOUT messages that are user facing. CheckErr(err) is only used in cludo client for STDERR messages that result in the client exiting.
spkane
changed the title
Review logging and messaging
Improve logging and messaging (Configurable log levels & passing useful errors back to the client)
Feb 9, 2022
We're logging to two places
Logger()
andfmt.Printf()
- are they going to the same place (stdout)? If so, why use two separate calls.Also, many of our error messages are focused on the implementation ("Failed to initialize dohicky") instead of the impact ("Failed to connect to google.com").
The text was updated successfully, but these errors were encountered: