Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not building containers on every PR #295

Open
supakeen opened this issue Nov 15, 2024 · 2 comments
Open

Not building containers on every PR #295

supakeen opened this issue Nov 15, 2024 · 2 comments
Labels
ci good first issue Good for newcomers help wanted Extra attention is needed

Comments

@supakeen
Copy link
Owner

It seems like our GitHub actions for building containers run on every PR, taking up a bunch of time. Let's turn those off?

@supakeen supakeen added help wanted Extra attention is needed good first issue Good for newcomers ci labels Nov 15, 2024
@supakeen supakeen changed the title Building containers on every PR Not building containers on every PR Nov 15, 2024
@supakeen
Copy link
Owner Author

There is also some discussion going on the Python Discord regarding how/when containers are built and tagged (?), I'll tag @shtlrs on this since they mentioned that.

@shtlrs
Copy link
Contributor

shtlrs commented Nov 15, 2024

It seems like our GitHub actions for building containers run on every PR, taking up a bunch of time. Let's turn those off?

Why would you want to turn them off ? How much is it taking when you run them next to the tests worfklows ?

I think it's a good idea to check that whatever changes have been made build correctly and don't break anything. As long as you don't push that image, which is the case already, it's fine IMO. We do this in pydis as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants