Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 3.3 deprecated service declaration #115

Open
fdespier opened this issue Jul 4, 2017 · 2 comments
Open

Symfony 3.3 deprecated service declaration #115

fdespier opened this issue Jul 4, 2017 · 2 comments

Comments

@fdespier
Copy link
Contributor

fdespier commented Jul 4, 2017

Hi @suncat2000,

Autowiring services based on the types they implement is deprecated since Symfony 3.3 and won't be supported in version 4.0.You should rename (or alias) the "mobile_detect.device_view" service to "SunCat\MobileDetectBundle\Helper\DeviceView" instead.

What do you think to make a new branch 2.X to handle new version of Symfony (>3.4) ?
@20uf
Copy link

20uf commented Jul 7, 2017

👍

@fdespier fdespier mentioned this issue Jul 7, 2017
Closed
@xabbuh
Copy link
Contributor

xabbuh commented Jul 7, 2017

Do you really want to maintain two branches just to avoid some if conditions inside the DI extension class? I don't think that's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fdespier @xabbuh @20uf