Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "shadowLocale" to "shadowBaseLocale". #579

Open
Quehnie opened this issue May 31, 2021 · 0 comments
Open

Rename "shadowLocale" to "shadowBaseLocale". #579

Quehnie opened this issue May 31, 2021 · 0 comments

Comments

@Quehnie
Copy link
Contributor

Quehnie commented May 31, 2021 •
edited
Loading

Q A
Bug? no
New Feature? no
SuluArticleBundle Version 2.3.0
Sulu Version 2.3.0

Actual Behavior

There is a different variable naming for pages and articles with activated shadowLocale / shadowBaseLocale.

Expected Behavior

Use the same variable name (because canonical-tag is influenced by it)

Steps to Reproduce

Create a page and an article with Shadow-pages and check the shadowBaseLocale variable.

Possible Solutions

A quickfix is to default the variable like shadowBaseLocale|default(shadowLocale|default())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Quehnie